-
Notifications
You must be signed in to change notification settings - Fork 903
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More explanation for OTLP transport protocols #1790
Conversation
0a844e8
to
f428e8c
Compare
- `http/protobuf` for protobuf-encoded data over HTTP connection | ||
- `http/json` for JSON-encoded data over HTTP connection | ||
|
||
SDKs MUST support either `grpc` or `http/protobuf` and SHOULD support both. They also MAY support `http/json`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't seen a definitive analysis in the ticket of why one of protobuf-based protocols is a MUST, can you elaborate?
Specifically, in the past we've always had issues with supporting Thrift in the browser - I don't know the current state of protobuf for browser, but according to #1764 (comment) it's a similar story, JSON is preferred.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#1764 (comment) and #1764 (comment)
It was also discussed during the last maintainers meeting (https://youtu.be/ZqQ4sbOsvLs?t=887) and this decision was made there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps instead of SDKs
, Languages
is more obvious? I suppose the intent is that JS supports at least protobuf for node users, and if protobuf is prohibitive in a browser it can also support JSON for that specific use case.
I think we are ready to go. @iNikem would you mind adding a Changelog entry? Thanks! |
@carlosalberto done. |
Fixes #1764
Changes
More explanation for OTLP transport protocols. Also clearly state that the support for one of the
grpc
orhttp/protobuf
is required andhttp/json
is not enough.